STM32 ADC: Rename sequencer and oversampler and fix macro issue #97525
Conversation
zephyrbot
added
area: Devicetree Bindings
area: ADC
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
anangl,
djiatsaf-st,
erwango,
etienne-lms,
marwaiehm-st and
mathieuchopstm
There was a problem hiding this comment.
I think this needs a note to be added in migration guide (or release notes? I don't know which one would be more appropriate) since it changes an existing property.
+ Nit: I'd mention explicitly what was fixed (macro ANY_ADC_INTERNAL_REGULATOR_TYPE_IS) in commit message
|
The change only impacts the dtsi files. Boards and users aren't impacted by the renaming of these parameters since they completely depend on HW and the type of ADC in use. They are fixed and not supposed/made to be modified. As such, I don't think it deserves to be in the migration guide. |
…ssue In STM32 ADC binding, rename the possible values of the sequencer and oversampler properties to use lowercase string, similar to the internal regulator. Adapts the driver and the dtsi with the new values. Fixes a macro issue in the driver. Since the value from the dtsi didn't start with internal_regulator_, the reconstruction of the defines by the macro ANY_ADC_INTERNAL_REGULATOR_TYPE_IS was missing this prefix and the comparison failed. Add a new argument to the IS_EQ_STRING_PROP to be able to insert such a prefix. Signed-off-by: Guillaume Gautier <[email protected]>
gautierg-st
force-pushed
the
adc_rename_seq_ovs
branch
from
c8270b6 to
6b188c0
Compare
Comment updated with more detail (hoping it is clear enough, but explaining macro magic is quite hard). |
|
5 participants
In STM32 ADC binding, rename the possible values of the sequencer and oversampler properties to use lowercase string, similar to the internal regulator.
Adapts the driver and the dtsi with the new values.
Fixes a macro issue in the driver (adds a prefix that were missing).